[ovs-dev] Regarding your Ethernet address wildcard match patch

[Ben Pfaff]

OFPFW_* are OpenFlow 1.0 protocol constants.  The FWW_* masks in struct
flow_wildcards coincide where it is convenient and not otherwise.

I don't understand why you're asking these questions.  Joe is clearly on
the right track with his patches.

On Thu, May 17, 2012 at 12:58:02PM +0800, YIMIN CHEN wrote:
> Hi Ben,
> 
> I am new to the code, so please pardon my questions.
> 
> Based on my current understanding of the code, the wildcard fields in
> flow_wildcards is used in the rule to store the wildcard mask for
> run-time match. OFPFW_DL_SRC_MASK, like OFPFW_NW_SRC_MASK, can be used
> to pass the wildcard bits in openflow messages to ovs. I don't have
> access to source code at this moment, but I remember there was some
> utility function that creates the ip mask to store in rule at rule
> creation, based on OFPFW_NW_SRC_MASK.
> 
> Is my understanding correct?
> 
> Thanks!
> Yimin
> 
> On Thu, May 17, 2012 at 12:49 PM, Ben Pfaff <blp at nicira.com> wrote:
> > The place that Joe put it, in struct flow_wildcards.
> >
> > On Thu, May 17, 2012 at 12:47:26PM +0800, YIMIN CHEN wrote:
> >> Hi Ben,
> >>
> >> I was following the way IP mask is passing the wildcard down to dp. We
> >> need several bits to represent the mac addr mask, instead of the
> >> current OFPFW_DL_SRC single bit. What is your advise on the proper
> >> place to specify the wildcard bits?
> >>
> >>
> >> Thanks!
> >> Yimin
> >>
> >> On Thu, May 17, 2012 at 12:33 PM, Ben Pfaff <blp at nicira.com> wrote:
> >> > On Thu, May 17, 2012 at 11:08:33AM +0800, YIMIN CHEN wrote:
> >> >> 2) do we also need to change the OFPFW_DL_SRC in ofp_flow_wildcards to
> >> >> OFPFW_DL_SRC_MASK? This will move DL_TYPE by many bits, and I am
> >> >> wondering whether this is the right way to do.
> >> >
> >> > No.  It wouldn't make sense to do that.