[ovs-dev] [RFC v3 03/19] odp-util: Add tun_key to parse_odp_key_attr()
Ben Pfaff
blp at nicira.com
Thu May 17 16:04:42 UTC 2012
On Thu, May 17, 2012 at 05:59:02PM +0900, Simon Horman wrote:
> Cc: Kyle Mestery <kmestery at cisco.com>
> Signed-off-by: Simon Horman <horms at verge.net.au>
I think that this is inconsistent with patch 1, which I read as
printing these attributes in the form "ipv4_tunnel(...)" not
"tun_key(...)". The output form should be valid for input.
You should add some tests for the ipv4_tunnel() formatting and parsing
to tests/odp.at.
More information about the dev
mailing list