[ovs-dev] [PATCH] vswitchd: log skb_mark and skb_priority

Thomas Graf tgraf at redhat.com
Sat Dec 1 07:59:11 UTC 2012


On 12/01/2012 01:27 AM, Jesse Gross wrote:
> On Fri, Nov 30, 2012 at 4:24 PM, Ben Pfaff <blp at nicira.com> wrote:
>> On Fri, Nov 30, 2012 at 04:20:33PM -0800, Jesse Gross wrote:
>>> It might not be a bad idea to make mark hex as well.
>>
>> I don't know anything about the semantics of skb_mark.  I'll take your
>> word for it.
>
> I think it's pretty much user-defined unstructured data.  I don't
> think there is a strong reason to chose one or the other but I find
> binary blobs easier to read in hex.

The field used to be called nfmark when it was only used within the
netfilter subsystem. It later became generic when the TC and routing
layer started using it as well.

Best practise so far has been to print it in hex and pare it with
strtoul(..., 0) semantics but as Jesse says, it's absolutely
unstructured, therefore no strict rules.


More information about the dev mailing list