[ovs-dev] [PATCH] ovs-vsctl: Allow command-specific options to mingle with global options.

Adam Heath doogie at brainfood.com
Fri Nov 2 21:21:56 UTC 2012


On 11/02/2012 04:19 PM, Ben Pfaff wrote:
> I still don't understand.  Why would an existing script call ovs-vsctl
> with --may-exist as a global option?  The call would not do anything
> useful, because it would exit with a fatal error every time.  Taking
> this argument to its logical conclusion, one must never extend any
> program by adding a new option, because it could break some existing
> script that tries to use that (nonexistent) option.

Exactly.  Your patch breaks existing scripts, by suddenly allowing for
--may-exist to work where it used to not.

I'm saying you should just change the error message, but do not allow
for it to be used as a global option.



More information about the dev mailing list