[ovs-dev] Bug#691508: [PATCH] ovs-vsctl: Allow command-specific options to mingle with global options.

Adam Heath doogie at brainfood.com
Tue Nov 6 18:01:50 UTC 2012


On 11/06/2012 11:10 AM, Ben Pfaff wrote:
> On Fri, Nov 02, 2012 at 02:26:20PM -0700, Ben Pfaff wrote:
>> On Fri, Nov 02, 2012 at 04:21:56PM -0500, Adam Heath wrote:
>>> On 11/02/2012 04:19 PM, Ben Pfaff wrote:
>>>> I still don't understand.  Why would an existing script call ovs-vsctl
>>>> with --may-exist as a global option?  The call would not do anything
>>>> useful, because it would exit with a fatal error every time.  Taking
>>>> this argument to its logical conclusion, one must never extend any
>>>> program by adding a new option, because it could break some existing
>>>> script that tries to use that (nonexistent) option.
>>>
>>> Exactly.  Your patch breaks existing scripts, by suddenly allowing for
>>> --may-exist to work where it used to not.
>>
>> You still haven't explained why an existing script would call
>> ovs-vsctl with --may-exist as a global option.  Why would it do that?
>>
>>> I'm saying you should just change the error message, but do not allow
>>> for it to be used as a global option.
>>
>> It's an option, and it's easier to do than the alternative patch that
>> I sent out, but I don't understand why you think it will break any
>> real script.  Who is in the habit of writing useless scripts that do
>> nothing but provoke errors?
> 
> Do you have any further comment?

If you don't see the issue, then I don't feel like trying to convince
you of it.  I've moved beyond the problem anyways, as my scripts
explictly check for existance of whatever before attempting to create
whatever.



More information about the dev mailing list