[ovs-dev] [PATCH 18/18] ofp-util: Optimize ofputil_version_bitmap_scanr

Simon Horman horms at verge.net.au
Wed Nov 7 00:51:28 UTC 2012


On Tue, Nov 06, 2012 at 04:49:07PM -0800, Ben Pfaff wrote:
> On Wed, Nov 07, 2012 at 09:45:59AM +0900, Simon Horman wrote:
> > Do you have any thoughts on if it is worth implementing something
> > similar for bitmap_scan() using ffs()?
> 
> I've never seen bitmap_scan() show up in profiling data so it's a low
> priority.
> 
> The current implementation has the advantage of being obviously
> correct.  A smarter implementation would need a (fairly thorough?)
> test.

Understood. It sounds like we should leave it as is,
no point fixing something that isn't broken.



More information about the dev mailing list