[ovs-dev] [PATCH 01/14] ofp-util: Correct length of hello version bitmap

Simon Horman horms at verge.net.au
Mon Nov 12 00:38:39 UTC 2012


On Fri, Nov 09, 2012 at 10:07:02AM -0800, Ben Pfaff wrote:
> On Wed, Nov 07, 2012 at 05:02:59PM +0900, Simon Horman wrote:
> > The length of the hello version bitmap is measured in bytes
> > so the return value of sizeof is sufficient. Dividing
> > this by CHAR_BIT (=8) seems to be an artifact of reworking
> > a previous version of this code.
> > 
> > Signed-off-by: Simon Horman <horms at verge.net.au>
> 
> Ouch.  That's nasty.
> 
> I pushed this patch, followed by other bug fixes and tests.

Thanks.



More information about the dev mailing list