[ovs-dev] [cleanups 11/12] netdev-linux: Don't log vport warnings when kernel datapath not loaded.

Justin Pettit jpettit at nicira.com
Fri Nov 16 08:03:04 UTC 2012


The *_get_stats functions call get_stats_via_vport(), which tries to get
information about ports attached to the kernel datapath.  When a pure
userspace switch is used (eg, the OVS kernel module isn't loaded), ports
are not attached to a kernel datapath, so warnings get logged.  This
commit handles that case and doesn't log a warning.  However, if the
kernel datapath is loaded, ports attached to a userspace datapath will
still log a warning.

Signed-off-by: Justin Pettit <jpettit at nicira.com>
---
 lib/netdev-linux.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c
index b813968..5b4d1a3 100644
--- a/lib/netdev-linux.c
+++ b/lib/netdev-linux.c
@@ -1347,7 +1347,7 @@ get_stats_via_vport(const struct netdev *netdev_,
         int error;
 
         error = netdev_vport_get_stats(netdev_, stats);
-        if (error) {
+        if (error && error != ENOENT) {
             VLOG_WARN_RL(&rl, "%s: obtaining netdev stats via vport failed "
                          "(%s)", netdev_get_name(netdev_), strerror(error));
         }
-- 
1.7.5.4




More information about the dev mailing list