[ovs-dev] [cleanups 08/12] bridge: Introduce iface_is_internal() function.
Ben Pfaff
blp at nicira.com
Fri Nov 16 17:51:45 UTC 2012
On Fri, Nov 16, 2012 at 12:03:01AM -0800, Justin Pettit wrote:
> This will have an additional caller in the future.
>
> Signed-off-by: Justin Pettit <jpettit at nicira.com>
I would think it more natural to write this:
if (!strcmp(iface->type, "internal") || !strcmp(iface->name, br->name)) {
return true;
} else {
return false;
}
as:
return !strcmp(iface->type, "internal") || !strcmp(iface->name, br->name);
Thanks,
Ben.
More information about the dev
mailing list