[ovs-dev] [PATCHv2] ofproto-dpif: Remove datapath flows of deleted ports.

Ben Pfaff blp at nicira.com
Fri Nov 16 20:19:48 UTC 2012


On Fri, Nov 16, 2012 at 12:00:05PM -0800, Justin Pettit wrote:
> Commit acf608 (ofproto-dpif: Use a single underlying datapath across
> multiple bridges.) causes datapath flows from deleted ports to not be
> removed.  The issue is that the code that bulk deletes old flows doesn't
> know the datapath port number that makes up the datapath flow
> definition.  This commit keeps track of the datapath port in the facet
> for use when the datapath flow eventually needs to be removed.
> 
> Signed-off-by: Justin Pettit <jpettit at nicira.com>

Would you mind adding some rationale to the comment on the 'odp_in_port'
member in struct subfacet?  Otherwise I'll come along in a few months
and have to figure out why we need this.

Otherwise this looks good, thank you.



More information about the dev mailing list