[ovs-dev] [PATCH] automake: Always include route-table.h in sources.

Ben Pfaff blp at nicira.com
Mon Nov 19 23:26:38 UTC 2012


As an experiment, I moved lib/route-table.h into an "if ESX" block,
and it still got distributed on a non-ESX build.  Also, I notice that
the BSD-only .c and .h files still get distributed even on non-BSD.

So I think something else must have been at work.

On Mon, Nov 19, 2012 at 03:18:05PM -0800, Ethan Jackson wrote:
> Im pretty sure it did at some point in time. This patch has been sitting in
> my repo for a long time and I can't seem to figure out what problem I was
> trying to solve.  I'll shelve it for now.
> 
> Ethan
> 
> 
> On Mon, Nov 19, 2012 at 1:44 PM, Ben Pfaff <blp at nicira.com> wrote:
> 
> > On Mon, Nov 19, 2012 at 01:32:01PM -0800, Ethan Jackson wrote:
> > > The Linux, ESX, and BSD route table implementations all require
> > > route-table.h.  However, it was only being included as a source in
> > > the Linux build.
> > >
> > > Signed-off-by: Ethan Jackson <ethan at nicira.com>
> >
> > This shouldn't have any effect.  It basically doesn't matter where you
> > list .h files as long as you list them somewhere.
> >
> > Did this fix any actual bug that you encountered?
> >



More information about the dev mailing list