[ovs-dev] [PATCHv4] datapath: add skb mark matching and set action

Ben Pfaff blp at nicira.com
Wed Nov 21 21:41:08 UTC 2012


On Wed, Nov 21, 2012 at 01:33:17PM -0800, Ansis Atteka wrote:
> On Tue, Nov 20, 2012 at 3:15 PM, Ben Pfaff <blp at nicira.com> wrote:
> > On Tue, Nov 20, 2012 at 03:05:24PM -0800, Ansis Atteka wrote:
> >> This patch adds support for skb mark matching and set action.
> >>
> >> Signed-off-by: Ansis Atteka <aatteka at nicira.com>
> >
> > I would increment FLOW_WC_SEQ to draw attention to some other places
> > that might require updates.
> I just incremented FLOW_WC_SEQ. It seems that nothing additional needs
> to be done for skb marks.
> 
> But, what got my attention, is that match_format() function accepts
> 'priority' as argument. Nevertheless, it seems that two different
> 'priorities' are being used interchangeably as argument in this
> function:
> 1. rule priority
> 2, skb/packet priority

Good catch!

It's supposed to be a rule priority, or OFP_DEFAULT_PRIORITY if
there's no appropriate rule priority (so that no priority should get
printed).



More information about the dev mailing list