[ovs-dev] [PATCH OF12+ 1/4 v3] OpenFlow 1.2 fixes

Ben Pfaff blp at nicira.com
Mon Nov 26 18:13:08 UTC 2012


On Mon, Nov 26, 2012 at 06:17:08PM +0200, Jarno Rajahalme wrote:
>    OpenFlow 1.2 protocol fixes: Add OFPP_ANY to include/openflow/openflow-1.1.h,
>    and allow it as a port in queue stats request. Make ovs_ofctl use OFPP_ANY
>    instead of OFPP_ALL for queue stats requests on OF 1.1+.
>    Do not check out_group on flow_mod unless the command is DELETE*.
> 
> As part of the change to all clients to use OFPP_ANY regardless of version, this patch
> changes "none" ports print out. "none" is still accepted on input for backwards compatibility,
> but it prints out as "ANY". To make this less confusing, I changed the test cases to use
> "controller" or "any" instead of "none". The test case that tests for both "none" and "controller"
> still tests for them.

I broke this into two patches and re-sent it as:
        http://openvswitch.org/pipermail/dev/2012-November/023321.html
        http://openvswitch.org/pipermail/dev/2012-November/023322.html
Will you take a look?

I need Signed-off-by: lines for each of the patches that you sent.
(It's easier if you include them in the original patches.)  Here's the
information on Signed-off-by: from SubmittingPatches:

Please sign off on the patch as a submitter, and be sure to have the
author(s) sign off for patches that you did not author.

Simply include your name and email address as the last line of the commit
message before any comments (and author too, if that is not you):

Signed-off-by: Author Name <author.name at email.address...>
Signed-off-by: Submitter Name <submitter.name at email.address...>

By doing this, you are agreeing to the Developer's Certificate of Origin
(see below for more details).

Developer's Certificate of Origin
---------------------------------

To help track the author of a patch as well as the submission chain,
and be clear that the developer has authority to submit a patch for
inclusion in openvswitch please sign off your work.  The sign off
certifies the following:

    Developer's Certificate of Origin 1.1

    By making a contribution to this project, I certify that:

    (a) The contribution was created in whole or in part by me and I
        have the right to submit it under the open source license
        indicated in the file; or

    (b) The contribution is based upon previous work that, to the best
        of my knowledge, is covered under an appropriate open source
        license and I have the right under that license to submit that
        work with modifications, whether created in whole or in part
        by me, under the same open source license (unless I am
        permitted to submit under a different license), as indicated
        in the file; or

    (c) The contribution was provided directly to me by some other
        person who certified (a), (b) or (c) and I have not modified
        it.

    (d) I understand and agree that this project and the contribution
        are public and that a record of the contribution (including all
        personal information I submit with it, including my sign-off) is
        maintained indefinitely and may be redistributed consistent with
        this project or the open source license(s) involved.



More information about the dev mailing list