[ovs-dev] [PATCH] flow: use rule priority in match_format() function

Ansis Atteka aatteka at nicira.com
Tue Nov 27 21:35:37 UTC 2012


On Tue, Nov 27, 2012 at 11:28 AM, Ben Pfaff <blp at nicira.com> wrote:
> On Tue, Nov 27, 2012 at 10:45:42AM -0800, Ansis Atteka wrote:
>> The flow_format() function was incorrectly passing skb_priority
>> to the match_format() function. match_format() function instead
>> expects rule priority.
>>
>> Signed-off-by: Ansis Atteka <aatteka at nicira.com>
>
> Good catch, thank you.
>
> Will you please cite the commit that added the bad match_format() call
> in the change log, so that it is easy to see what versions are
> affected?

Sure, skb_priority has been used like this since the very beginning -
Nov 1 2011 (abff858b5ad310a529d5a5ac2a230ee4ac9736db datapath: Convert
kernel priority actions into match/set.). Though, that particular line
of code has been re-factored multiple times since then.

Should I try to backport this all the way back to branch-1.4?



More information about the dev mailing list