[ovs-dev] [PATCH] datapath: Use RCU callback when detaching netdevices.

Ben Pfaff blp at nicira.com
Wed Nov 28 21:43:06 UTC 2012


On Wed, Nov 28, 2012 at 12:25:07PM -0800, Jesse Gross wrote:
> Currently, each time a device is detached from an OVS datapath
> we call synchronize RCU before freeing associated data structures.
> However, if a bridge is deleted (which detaches all ports) when
> many devices are connected then there can be a long delay.  This
> switches to use call_rcu() to group the cost together.
> 
> Reported-by: Justin Pettit <jpettit at nicira.com>
> Signed-off-by: Jesse Gross <jesse at nicira.com>

Looks good to me, thanks.

I verified that we already call rcu_barrier() on unload and that the
functions called from free_port_rcu() appear to be safe to invoke from
an RCU callback.



More information about the dev mailing list