[ovs-dev] [PATCH] openvswitch: Remove Linux bridge compatibility.

[Ben Pfaff]

On Fri, Nov 30, 2012 at 06:53:59PM -0800, Pravin B Shelar wrote:
> Currently brcompat does not on master due to recent
> datapath changes. We have decided to remove it as it is
> not used very widely.
> 
> Signed-off-by: Pravin B Shelar <pshelar at nicira.com>

Thank you!

I did a test build.  "make check" passed.

The ovs-ctl.8 manpage now has no step 2 in its list of steps for
"start".  Please renumber steps 3 and up.

I see a few remaining references to bridge compatibility to be removed
from the FAQ:

FAQ:       - Bridge compatibility, that is, support for the ovs-brcompatd
FAQ:         daemon that (if you enable it) lets "brctl" and other Linux
FAQ:         We do not expect bridge compatibility to ever be available in
FAQ:         upstream Linux.  If you need bridge compatibility, use the

I believe that this will fail to compile on kernels earlier than Linux
2.6.36, because it removes BRIDGE_MUTUAL_EXCLUSION from
datapath/compat.h but still invokes it in datapath/vport-netdev.c.  (I
would consider moving the macro's content into vport-netdev.c, rather
than reintroducing the macro.)

Only genetlink-openvswitch.c now includes genetlink.inc, so it would be
reasonable to insert genetlink.inc's contents into
genetlink-openvswitch.c and then remove the latter.

Jesse should of course also review the datapath changes.

Thanks,

Ben.