[ovs-dev] [PATCH] build: Add support for building RPMs for Fedora Linux
blp at nicira.com
Tue Oct 2 04:31:39 UTC 2012
On Mon, Oct 01, 2012 at 05:20:32PM -0400, Kyle Mestery wrote:
> Add RPM specfiles for building OVS for Fedora Linux. This
> allows users of the upstream project the ability to
> generate RPMs for their Open vSwitch needs.
> Signed-off-by: Kyle Mestery <kmestery at cisco.com>
Thanks. I have only a few comments.
The ====s below extend past the title:
> + How to Install Open vSwitch on Fedora Linux
> + =======================================================
> +This document describes how to build and install Open vSwitch on a Fedora
> +Linux host. If you want to install Open vSwitch on a generic Linux host,
> +see INSTALL.Linux instead.
The instructions are very clear. Thanks for that.
> +We have tested these instructions with Fedora 15.
I think we normally recommend bugs at openvswitch.org for bug reports:
> +Reporting Bugs
> +Please report problems to dev at openvswitch.org.
INSTALL.Fedora has an extra blank line at the end.
The spec files mention "OpenSource Security Ralf Spenneberg
<ralf at os-s.net>" as vendor and in the changelog. Where does that come
from? (Do we need to get Ralf Spenneberg's Signed-off-by?)
I think that we can drop the %post fragment that mentions xhad. That's
a proprietary high-availability daemon that, as far as I know, only
XenServer uses. (Do our RHEL spec files include this? They can
probably omit it too, then.)
It looks like the RPM omits ovs-bugtool and much of the infrastructure
that it uses. It would be nice to include it, because ovs-bugtool
occasionally makes bugs much easier to find.
More information about the dev