[ovs-dev] [PATCH] datapath: Add basic MPLS support to kernel

Simon Horman horms at verge.net.au
Thu Oct 4 08:58:10 UTC 2012


On Wed, Oct 03, 2012 at 12:17:16PM -0700, Jesse Gross wrote:
> From: Leo Alterman <lalterman at nicira.com>
> 
> Allow datapath to recognize and extract MPLS labels into flow keys
> and execute actions which push, pop, and set labels on packets.
> 
> Signed-off-by: Leo Alterman <lalterman at nicira.com>


Hi,

As a method of reviewing this I've been reworking Ravi's user-space
datapath and non-datapath code to match up with this kernel datapath
implementation.

That part seems to be working out well, though I'd like to clean
up my efforts a little before posting.


One thing that am curious about is if OVS_ACTION_ATTR_SET_MPLS is needed.

I believe that setting the label value (the top 20 bits), tc and bos can be
handled using set-field actions for OF1.2+ (OXM) and load actions for NXM.

And I believe that manipulation of the TTL can be handled by TTL-specific
actions that are not part of this datapath implementation but presumably
will be added later.

I believe that the above would be is in keeping with the OF1.2 and OF1.3
specifications wile also providing an NX extension mechanism.



More information about the dev mailing list