[ovs-dev] [PATCH 05/17] connmgr: connmgr_destroy(): Paramatise Open Flow version

Ben Pfaff blp at nicira.com
Thu Oct 4 17:49:26 UTC 2012


On Thu, Oct 04, 2012 at 11:41:20AM +0900, Simon Horman wrote:
> Signed-off-by: Simon Horman <horms at verge.net.au>

I think the commit message should mention connmgr_run() instead of
connmgr_destroy().  The commit doesn't affect connmgr_destroy()
as far as I can tell.

The layering seems wrong to me.  I don't think that connmgr_run()
should have to know what OpenFlow versions should be accepted on
passive connections.  (It doesn't need that information for active
connections.)  I think that a better approach would be to move the
version information from pvconn_accept() to pvconn_open().

Thanks,

Ben.



More information about the dev mailing list