[ovs-dev] [PATCH] config: Add explicit support for building on ESX.

Ben Pfaff blp at nicira.com
Tue Oct 9 21:18:13 UTC 2012


On Tue, Oct 09, 2012 at 01:54:28PM -0700, Ethan Jackson wrote:
> > Does the 'argv' code in command-line.c actually malfunction on ESX?
> > It'd be nice to just leave it in, if not.  It's not really tied to
> > having the Linux datapath, it's orthogonal.  (It should actually work
> > on many Unix and Unix-like systems, but we specialize it to Linux
> > pending testing on other systems.)
> 
> Yes I disabled it because I had verified that according to ps the
> process title was not set.

OK, thanks.

> > Does ESX have /proc/self/fd/* that works like the Linux version?  If
> > so then __linux__ is the right test for put_fd_filename(), otherwise
> > LINUX_DATAPATH seems good enough for now.
> 
> Nope, it doesn't have /proc/self/fd, or /proc/self for that matter.

OK, thanks.

> > In timeval.c, if we use LINUX_DATAPATH as the check for cache_time,
> > then can we make that a compile-time constant again?
> 
> I'm not sure I totally understand what you're asking for here.  You
> want cache_time to be a constant?  That can be changed at runtime in
> some cases.

Maybe I'm mistaken, but IIRC ESX is the only case we know of where
timer_create() doesn't work.  We previously found this out only at
runtime, but with your change we will instead disable timer caching at
compile time so there's now (again) no need to disable it at runtime.
No?



More information about the dev mailing list