[ovs-dev] [PATCH] nicira-ext: Correct and improve nx_flow_update_abbrev comment.

Jean Tourrilhes jt at hpl.hp.com
Thu Oct 11 17:37:56 UTC 2012


On Wed, Oct 10, 2012 at 10:48:35PM -0700, Ben Pfaff wrote:
> Notifications always precede a barrier that follows a given flow_mod,
> not a barrier that precedes a flow_mod as the text here previously claimed.
> 
> Also, the text about abbreviated notifications is equally applicable
> to normal, unabbreviated notifications, so say that explicitly.
> 
> Reported-by: Jean Tourrilhes <jt at hpl.hp.com>
> Signed-off-by: Ben Pfaff <blp at nicira.com>

My name is Jean Tourrilhes and I approve this message.
Ack-by: Jean Tourrilhes <jt at hpl.hp.com>

> ---
>  include/openflow/nicira-ext.h |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/include/openflow/nicira-ext.h b/include/openflow/nicira-ext.h
> index 75bf6db..7e49550 100644
> --- a/include/openflow/nicira-ext.h
> +++ b/include/openflow/nicira-ext.h
> @@ -2173,10 +2173,10 @@ OFP_ASSERT(sizeof(struct nx_flow_update_full) == 24);
>   * change in future versions of Open vSwitch.
>   *
>   * OVS will always send the notifications for a given flow table change before
> - * the reply to a OFPT_BARRIER_REQUEST request that precedes the flow table
> - * change.  Thus, if the controller does not receive an abbreviated
> - * notification for a flow_mod before the next OFPT_BARRIER_REPLY, it will
> - * never receive one. */
> + * the reply to a OFPT_BARRIER_REQUEST request that follows the flow table
> + * change.  Thus, if the controller does not receive an abbreviated (or
> + * unabbreviated) notification for a flow_mod before the next
> + * OFPT_BARRIER_REPLY, it will never receive one. */
>  struct nx_flow_update_abbrev {
>      ovs_be16 length;            /* Length is 8. */
>      ovs_be16 event;             /* NXFME_ABBREV. */
> -- 
> 1.7.10.4
> 



More information about the dev mailing list