[ovs-dev] [PATCH 1/3] ofp-util: Correct setting of Flow Mod cookie on encode

Ben Pfaff blp at nicira.com
Fri Oct 12 17:14:19 UTC 2012

On Fri, Oct 12, 2012 at 09:26:27AM +0900, Simon Horman wrote:
> When the command of a Flow Mod messages is ADD the cookie should be set as
> fm->cookie, internally this is the new cookie value to be set. Otherwise it
> should be set as fm->new_cookie, internally this is the cookie value to match.

I think you have the above backward.  It doesn't match the code.

> Also remove 'XXX' marker from the matching code in the decoder.
> I am now comfortable with the implementation.
> Signed-off-by: Simon Horman <horms at verge.net.au>

I corrected the change log and applied this to master.  Thank you!

More information about the dev mailing list