[ovs-dev] [PATCH 1/2] cfm: Scope CFM packets to key zero.

Ben Pfaff blp at nicira.com
Sat Oct 13 23:29:32 UTC 2012


Thanks.  As a nit, the first period in that looks like it should be a
comma.

On Sat, Oct 13, 2012 at 02:26:49PM -0700, Ethan Jackson wrote:
> Good idea, I've added the following paragraph
> 
>       <p>
>           When operating over tunnels which have no <code>in_key</code>, or an
>           <code>in_key</code> of <code>flow</code>.  CFM will only accept CCMs
>           with a tunnel key of zero.
>       </p>
> 
> Ethan
> 
> On Fri, Oct 12, 2012 at 8:12 PM, Ben Pfaff <blp at nicira.com> wrote:
> > On Fri, Oct 12, 2012 at 07:40:22PM -0700, Ethan Jackson wrote:
> >> Before this patch, when a tunnel is configured with key=flow, CFM
> >> didn't verify that incoming packets had the appropriate key of
> >> zero.  This could cause the CFM module to consume packets which
> >> weren't actually intended for it.
> >>
> >> Bug #13542.
> >> Signed-off-by: Ethan Jackson <ethan at nicira.com>
> >
> > This looks good to me.
> >
> > It might be good to add some words about this verification in the
> > documentation for CFM in vswitch.xml.



More information about the dev mailing list