[ovs-dev] [PATCH v15] ofp-msgs: Open Flow 1.1 and 1.2 Queue Status Messages

Simon Horman horms at verge.net.au
Sun Oct 14 00:42:30 UTC 2012


On Fri, Oct 12, 2012 at 09:56:26AM -0700, Ben Pfaff wrote:
> On Fri, Oct 12, 2012 at 01:03:04PM +0900, Simon Horman wrote:
> > This allows for encoding and decoding Open Flow 1.1 and 1.2 Queue Stats
> > Request and Reply messages.
> > 
> > Signed-off-by: Simon Horman <horms at verge.net.au>
> 
> Wow, you've gone through a lot of versions here.  Thanks for your
> patience.
> 
> "sparse" reported:
> 
> ../lib/ofp-util.c:4200:36: warning: incorrect type in argument 1 (different base types)
> ../lib/ofp-util.c:4200:36:    expected restricted __be16 [usertype] x
> ../lib/ofp-util.c:4200:36:    got restricted __be32 const [usertype] port_no
> 
> so I changed ofp11_queue_stats_request to ofp10_queue_stats_request in
> the OFP10_VERSION case of ofputil_decode_queue_stats_request().
> 
> There was also a missing blank line between function definitions.
> 
> I fixed that up and applied this to master.  Thank you!

Thanks, I'm pretty happy to get this one merged at last :)



More information about the dev mailing list