[ovs-dev] [PATCH 2/2] timeval: Add new "backtrace" appctl command.

Ben Pfaff blp at nicira.com
Mon Oct 15 00:37:05 UTC 2012


On Sun, Oct 14, 2012 at 05:13:07PM -0700, Ethan Jackson wrote:
> Good point.  Here's an incremental that switches to a pre-allocated
> array of 50 elements.

The last remaining issue I see is that the compiler might reorder the
assignments in backtrace_cb() and in trace_run().  If so, that could
race with sigalrm_handler() and cause a segfault.  So I would add a
block_sigalrm()/unblock_sigalrm() around all of three of the assignments
in backtrace_cb(), and similarly in trace_run().  In the latter case
putting the unixctl_command_reply() after all the assignments is
probably a good idea, because although that function does not have
an obvious dependency on time advancing, it would be really surprising
for it to break when called from this context.

Thanks again for doing this.



More information about the dev mailing list