[ovs-dev] [PATCH v2 0/2] python/ovs: add tcp socket support

Ben Pfaff blp at nicira.com
Tue Oct 16 17:20:30 UTC 2012

On Tue, Oct 16, 2012 at 06:57:27AM +0900, Isaku Yamahata wrote:
> On Mon, Oct 15, 2012 at 12:10:16PM -0700, Reid Price wrote:
> > I see that Ben already reviewed and pushed, only saw a comment-typo
> > and a message-typo that Ben seems to have seen.  My only nit would be
> > using some generic Error for the parameter checking (ValueError, or
> > ovs-specific) instead of raising Exception. The register decorators /
> > helper classes seem reasonable and clean, if a little overkill
> > compared to a conditional in open().  Thanks!
> Thank you for review. Here's the patch to replace Exception with ValueError.

Thanks, I applied this to master.

More information about the dev mailing list