[ovs-dev] Bug#690712: Bug#690712: openvswitch-datapath-dkms: bashism in /bin/sh script

[Ben Pfaff]

severity 690712 normal
merge 690712 663051
thanks

On Tue, Oct 16, 2012 at 01:01:10PM -0500, Raphael Geissert wrote:
> Package: openvswitch-datapath-dkms
> Version: 1.4.2+git20120612-9
> Severity: important
> User: debian-release at lists.debian.org
> Usertags: goal-dash
> 
> Hello maintainer,
> 
> While performing an archive wide checkbashisms (from the 'devscripts' 
> package) check I've found your package containing a /bin/sh script making 
> use of a bashism.
> 
> checkbashisms' output:
> >possible bashism in
> >./usr/src/openvswitch-1.4.2+git20120612/xenserver/etc_xensource_scripts_vif
> > line 181 (alternative test command ([[ foo ]] should be [ foo ])):
> >if [[ $# -lt 2 ]]; then

This script doesn't ever get executed on Debian, only on a Citrix
XenServer (see the file name).  It's harmless in the Debian packaging.

Since this script doesn't ever get executed on Debian, it's not really
a good idea to ship it, because it causes false-positives like this,
and for other reasons.  This is therefore still a bug, though lower
priority.  This problem was already reported as bug #663051, so I'm
merging this new bug with that one.

Thanks,

Ben.