[ovs-dev] [PATCH 2/2] timeval: Optionally enable cached timing at configure time.
blp at nicira.com
Wed Oct 17 16:13:38 UTC 2012
On Tue, Oct 16, 2012 at 06:23:37PM -0700, Ethan Jackson wrote:
> Often when developing, it would be convenient to force OVS to
> either enable or disable cached timing so that a feature can be
> tested under both strategies.
> Signed-off-by: Ethan Jackson <ethan at nicira.com>
This looks good, but I wonder whether it would be better to make this a
command-line option or a runtime ovs-appctl feature, so that one doesn't
need to reconfigure and rebuild everything to test changes.
If we keep it a configure-time option, the comment below could be
improved to something like "Define to 1 to enable time caching, to 0 to
disable time caching, or leave undefined to use the default (as one
should ordinarily do)."
> + AC_DEFINE_UNQUOTED([CACHE_TIME], [$cache_time],
> + [Define to 1 if cached timing is enabled.])])])
Also, the --enable-cache-time help message should probably discourage users
from specifying it. Perhaps:
[Override time caching default (for testing only)])],
More information about the dev