[ovs-dev] [PATCH 3/3] datapath: Tunnel port without destination IP.

Ben Pfaff blp at nicira.com
Wed Oct 17 23:12:28 UTC 2012


On Sun, Oct 14, 2012 at 06:41:47PM -0700, Pravin B Shelar wrote:
> Following patch allow port create without any parameters. This is
> required for compatibility with future flow based tunneling
> where each type would have single vport with all parameter
> wild carded. So that all packet for all ports are received on
> the port and same port is used for sending all traffic for
> that tunnel type.
> 
> Signed-off-by: Pravin B Shelar <pshelar at nicira.com>
> CC: Kyle Mestery <kmestery at cisco.com>
> Cc: Simon Horman <horms at verge.net.au>
> Cc: Jesse Gross <jesse at nicira.com>

ovs_tnl_find_port() could be a lot cheaper in the null_ports case (I
think it could just check a 3-element array indexed on tunnel_type).
Oh, I guess network namespaces make it harder.  Maybe that's an
optimization for the future.

In tnl_set_config(), with port_table_lookup() moved to the end, do we
need to back out the ip_mc_inc_group() that we've done just above in
the multicast case?

I didn't look around for code that might not like daddr == 0.

Thanks,

Ben.



More information about the dev mailing list