[ovs-dev] [PATCH 3/3] datapath: Tunnel port without destination IP.

Pravin Shelar pshelar at nicira.com
Thu Oct 18 01:03:10 UTC 2012


On Wed, Oct 17, 2012 at 4:12 PM, Ben Pfaff <blp at nicira.com> wrote:
> On Sun, Oct 14, 2012 at 06:41:47PM -0700, Pravin B Shelar wrote:
>> Following patch allow port create without any parameters. This is
>> required for compatibility with future flow based tunneling
>> where each type would have single vport with all parameter
>> wild carded. So that all packet for all ports are received on
>> the port and same port is used for sending all traffic for
>> that tunnel type.
>>
>> Signed-off-by: Pravin B Shelar <pshelar at nicira.com>
>> CC: Kyle Mestery <kmestery at cisco.com>
>> Cc: Simon Horman <horms at verge.net.au>
>> Cc: Jesse Gross <jesse at nicira.com>
>
> ovs_tnl_find_port() could be a lot cheaper in the null_ports case (I
> think it could just check a 3-element array indexed on tunnel_type).
> Oh, I guess network namespaces make it harder.  Maybe that's an
> optimization for the future.
>
Right, we can optimize it in next release.

> In tnl_set_config(), with port_table_lookup() moved to the end, do we
> need to back out the ip_mc_inc_group() that we've done just above in
> the multicast case?
>
I am not sure if I understand comment correctly. But group refcnt will
be decremented if set_config returns error by free_mutable_rtnl().

> I didn't look around for code that might not like daddr == 0.
>
ok, I will see if I missed something.

Thanks,
Pravin.



More information about the dev mailing list