[ovs-dev] [PATCH 3/3] datapath: Tunnel port without destination IP.

Ben Pfaff blp at nicira.com
Thu Oct 18 01:59:42 UTC 2012


On Wed, Oct 17, 2012 at 06:03:10PM -0700, Pravin Shelar wrote:
> On Wed, Oct 17, 2012 at 4:12 PM, Ben Pfaff <blp at nicira.com> wrote:
> > In tnl_set_config(), with port_table_lookup() moved to the end, do we
> > need to back out the ip_mc_inc_group() that we've done just above in
> > the multicast case?
> >
> I am not sure if I understand comment correctly. But group refcnt will
> be decremented if set_config returns error by free_mutable_rtnl().

That's what I meant.  Thanks.

> > I didn't look around for code that might not like daddr == 0.
> >
> ok, I will see if I missed something.

OK, assuming you check around:
Acked-by: Ben Pfaff <blp at nicira.com>



More information about the dev mailing list