[ovs-dev] [PATCH] v8: datapath: Add support for tun_key to Open vSwitch datapath

Ben Pfaff blp at nicira.com
Thu Oct 18 21:51:26 UTC 2012

On Thu, Oct 18, 2012 at 02:25:05PM -0700, Pravin B Shelar wrote:
> This patch was posted by Kyle. I fixed few issues found in earlier
> version. Latest verison fixes patch according to comments rom Ben.

I looked over my previous comments to see how you updated the code based
on that.  I didn't re-review the whole patch, so if you made significant
other changes let me know.

In the changes, I see only a couple little style things.

In ovs_flow_from_nlattrs(), I see a couple of places where sizeof and
its operand have a space between them.  Kernel style frowns on that.

In gre_update_header,
	} else if (out_key ||
		   tunnel_type & TNL_T_PROTO_GRE64) {
could be written as one line.

With those comments:
Acked-by: Ben Pfaff <blp at nicira.com>

Thank you!

More information about the dev mailing list