[ovs-dev] [PATCH] v8: datapath: Add support for tun_key to Open vSwitch datapath

Ben Pfaff blp at nicira.com
Thu Oct 18 22:03:12 UTC 2012


On Thu, Oct 18, 2012 at 02:57:52PM -0700, Pravin Shelar wrote:
> On Thu, Oct 18, 2012 at 2:51 PM, Ben Pfaff <blp at nicira.com> wrote:
> > In the changes, I see only a couple little style things.
> >
> > In ovs_flow_from_nlattrs(), I see a couple of places where sizeof and
> > its operand have a space between them.  Kernel style frowns on that.
> >
> > In gre_update_header,
> >         } else if (out_key ||
> >                    tunnel_type & TNL_T_PROTO_GRE64) {
> > could be written as one line.
> >
> ok, I will fix code accordingly.

OK.

(Personally, I don't feel a need to re-review it.)



More information about the dev mailing list