[ovs-dev] [PATCH] timeval: Simplify poll interval logging.

Ben Pfaff blp at nicira.com
Fri Oct 19 05:16:19 UTC 2012


On Thu, Oct 18, 2012 at 07:16:24PM -0700, Ethan Jackson wrote:
> log_poll_interval() is a little bit too aggressive, and is
> therefore less useful than it could be.  This patch removes the
> mean interval calculation, and simply logs if the poll loop took
> longer than 1 second instead.
> 
> Signed-off-by: Ethan Jackson <ethan at nicira.com>
> ---
> 
> Note to the reviewer:
> 
> I personally am a bit skeptical of the mean interval calculation, but I may be
> wrong on this point.  I can add it back if necessary.  Also most of this patch
> is whitespace changes, it's easiest to review with the -w option.

All of it seems fine.  I'm unsure of the rationale for the new criteria
for coverage logging.  Off-hand, I would have just logged it whenever we
print the "unreasonably long poll interval" message.  Any particular
reason for the 100 ms criteria there?



More information about the dev mailing list