[ovs-dev] [PATCH] nicira-ext: Clarify behavior of overlapping src and dst for NXAST_REG_MOVE.

Ethan Jackson ethan at nicira.com
Sat Oct 20 17:51:35 UTC 2012


Acked-by: Ethan Jackson <ethan at nicira.com>


On Tue, Oct 16, 2012 at 1:01 PM, Ben Pfaff <blp at nicira.com> wrote:
> Reported-by: Pankaj Thakkar <thakkar at nicira.com>
> Signed-off-by: Ben Pfaff <blp at nicira.com>
> ---
>  include/openflow/nicira-ext.h |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/include/openflow/nicira-ext.h b/include/openflow/nicira-ext.h
> index 8e6af52..255e30d 100644
> --- a/include/openflow/nicira-ext.h
> +++ b/include/openflow/nicira-ext.h
> @@ -502,6 +502,10 @@ OFP_ASSERT(sizeof(struct nx_action_pop_queue) == 16);
>   * The switch will reject actions for which src_ofs+n_bits is greater than the
>   * width of 'src' or dst_ofs+n_bits is greater than the width of 'dst' with
>   * error type OFPET_BAD_ACTION, code OFPBAC_BAD_ARGUMENT.
> + *
> + * This action behaves properly when 'src' overlaps with 'dst', that is, it
> + * behaves as if 'src' were copied out to a temporary buffer, then the
> + * temporary buffer copied to 'dst'.
>   */
>  struct nx_action_reg_move {
>      ovs_be16 type;                  /* OFPAT_VENDOR. */
> --
> 1.7.2.5
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev



More information about the dev mailing list