[ovs-dev] [PATCH 01/18] vconn: Paramatise pvconn_open() over minimum OpenFlow version

Ben Pfaff blp at nicira.com
Wed Oct 24 06:04:09 UTC 2012


On Wed, Oct 24, 2012 at 08:59:57AM +0900, Simon Horman wrote:
> On Tue, Oct 23, 2012 at 09:00:42AM -0700, Ben Pfaff wrote:
> > On Thu, Oct 18, 2012 at 02:58:01PM +0900, Simon Horman wrote:
> > > The motivation for this is to avoid avoids needing to provide a minimu
> > > version parameter to pvconn_accept().  This will in turn avoid the need to
> > > pass version information to connmgr_run() when the range of accetable
> > > OpenFlow versions is made configurable.
> > > 
> > > Signed-off-by: Simon Horman <horms at verge.net.au>
> > 
> > What's the reason to do this if soon after the acceptable versions will
> > become configurable via bitmap?
> 
> To avoid version information being passed to connmgr_run(),
> regardless of if it is a minimum version or a bitmap.

OK, that's reasonable, and I didn't see that at first glance.

If you think it's better to separate those steps, then feel free to
leave #1 and #3 as separate patches.  Or if you agree that it makes
sense to squash them, go ahead and squash them.

Thanks,

Ben.



More information about the dev mailing list