[ovs-dev] [PATCH] ovs-ctl.in: Don't save flows if the daemons are not running.

Gurucharan Shetty gshetty at nicira.com
Wed Oct 24 20:19:24 UTC 2012


When a 'ovs-ctl restart' is executed and the userspace daemons
like ovsdb-server and ovs-vswitchd are not running, attempt to
save flows can wait forever. This also results in the daemons
from not getting started.

Signed-off-by: Gurucharan Shetty <gshetty at nicira.com>
---
 utilities/ovs-ctl.in |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/utilities/ovs-ctl.in b/utilities/ovs-ctl.in
index 9ce4973..e8b72ba 100755
--- a/utilities/ovs-ctl.in
+++ b/utilities/ovs-ctl.in
@@ -405,10 +405,12 @@ force_reload_kmod () {
 ## ------- ##
 
 restart () {
-    script_flows=`mktemp`
-    trap 'rm -f "${script_flows}"' 0 1 2 13 15
+    if daemon_is_running ovsdb-server && daemon_is_running ovs-vswitchd; then
+        script_flows=`mktemp`
+        trap 'rm -f "${script_flows}"' 0 1 2 13 15
 
-    action "Saving flows" save_flows
+        action "Saving flows" save_flows
+    fi
 
     # Restart the database first, since a large database may take a
     # while to load, and we want to minimize forwarding disruption.
-- 
1.7.2.5




More information about the dev mailing list