[ovs-dev] [PATCH] datapath: Add support for 3.6 kernel.
blp at nicira.com
Thu Oct 25 20:34:43 UTC 2012
On Thu, Oct 25, 2012 at 01:33:32PM -0700, Pravin Shelar wrote:
> On Thu, Oct 25, 2012 at 1:22 PM, Ben Pfaff <blp at nicira.com> wrote:
> > On Sat, Oct 27, 2012 at 01:07:35PM -0700, Pravin B Shelar wrote:
> >> Signed-off-by: Pravin B Shelar <pshelar at nicira.com>
> > ...
> >> +#if LINUX_VERSION_CODE >= KERNEL_VERSION(3,6,0)
> >> +#define NETLINK_CB_PORT_ID(skb) (NETLINK_CB((skb)).portid)
> >> +#else
> >> +#define NETLINK_CB_PORT_ID(skb) (NETLINK_CB((skb)).pid)
> >> +#endif
> > I'd be at least tempted to write:
> > #if LINUX_VERSION_CODE < KERNEL_VERSION(3,6,0)
> > #define portid pid
> > #endif
> portid is pretty common name, I am not sure if we can make this type
> of renaming cross kernel datapath.
I won't argue with that.
> > and similarly for snd_portid vs. snd_pid in genetlink.h, which would
> > skip the indirection macro.
> ok, I will change it.
Well, it's up to you (and Jesse), just pointing it out.
More information about the dev