[ovs-dev] [tests 00/22] bond tests, oftest support

Ben Pfaff blp at nicira.com
Fri Oct 26 00:01:56 UTC 2012

This series reflects two different development chains that both
involve improving the netdev-dummy implementation.

First, months ago I spent a week or so writing unit tests for the bonding
code.  The tests themselves, which are in the final patch of this series,
are half-baked.  But the patches on the run up to the tests patch are still

Second, after participating in a thread where OFTest failures were reported
against OVS, again, it occurred to me today (not for the first time) that
the problem is that OFTest isn't easy to run.  You need to be root, you
need a fairly dedicated machine, etc.  But that's only because OFTest
(which until today I'd never even tried out) wants to use real network
devices.  OFTest should be able to use OVS's dummy network devices instead,
over Unix domain sockets.  So this series enables that too, with the commit
"netdev-dummy: Add "pstream" option for connecting a dummy to a process".
A minor enhancement to OFTest is also necessary; I'll send that out

Ben Pfaff (22):
  netlink-socket: Don't bother logging SO_RCVBUFFORCE failure as
  poll-loop: Reduce high-CPU log messages from WARN to INFO.
  bond: Reduce log level from WARN to INFO for interface status
  tests: Set explicit bond mode in LACP test.
  bridge: Drop warning about the default bridge Ethernet address.
  ofproto-macros: Fail a test that logs a WARN or higher level message.
  netdev-dummy: Limit receive queue length to 100 packets.
  netdev-dummy: Factor some netdev_dummy_receive() code out into new
  netdev-dummy: Drop "nobody listened" reply from netdev-dummy/receive.
  netdev-dummy: Add "patch port"-like feature.
  netdev-dummy: Add a packet generator.
  netdev-dummy: Correctly maintain port statistics.
  netdev-dummy: Allow "netdev-dummy/set-admin-state" accept multiple
  netdev-dummy: Remove unneeded forward declaration.
  netdev-dummy: Add pcap feature.
  netdev-dummy: Add "pstream" option for connecting a dummy to a
  ofproto-dpif: Factor duplicated code into new function.
  ofproto-dpif: Report more detailed reason for flooding a packet.
  ofproto-dpif: Report port number consistently in "fdb/show" output.
  ofproto-dpif: Fix "ofproto/trace" of flow for local port.
  netdev-linux: Improve log message.
  bond: Add test for active-backup bond.

 lib/bond.c              |    6 +-
 lib/netdev-dummy.c      |  663 +++++++++++++++++++++++++++++++++++++++++++++--
 lib/netdev-linux.c      |    4 +-
 lib/netlink-socket.c    |    8 +-
 lib/packets.h           |    3 +
 lib/pcap.c              |   31 ++-
 lib/poll-loop.c         |    4 +-
 ofproto/ofproto-dpif.c  |   53 +++--
 tests/automake.mk       |    1 +
 tests/bond.at           |  349 +++++++++++++++++++++++++
 tests/lacp.at           |  428 ++++++++++++++++++++++++++++++-
 tests/ofproto-dpif.at   |    6 +-
 tests/ofproto-macros.at |    9 +-
 tests/testsuite.at      |    1 +
 vswitchd/bridge.c       |   10 -
 15 files changed, 1500 insertions(+), 76 deletions(-)
 create mode 100644 tests/bond.at


More information about the dev mailing list