[ovs-dev] [tests 13/22] netdev-dummy: Allow "netdev-dummy/set-admin-state" accept multiple interfaces.
Ben Pfaff
blp at nicira.com
Fri Oct 26 00:02:09 UTC 2012
Signed-off-by: Ben Pfaff <blp at nicira.com>
---
lib/netdev-dummy.c | 20 ++++++++++++--------
1 files changed, 12 insertions(+), 8 deletions(-)
diff --git a/lib/netdev-dummy.c b/lib/netdev-dummy.c
index cd19789..6722dcb 100644
--- a/lib/netdev-dummy.c
+++ b/lib/netdev-dummy.c
@@ -730,14 +730,18 @@ netdev_dummy_set_admin_state(struct unixctl_conn *conn, int argc,
}
if (argc > 2) {
- struct netdev_dev_dummy *dummy_dev;
+ int i;
- dummy_dev = shash_find_data(&dummy_netdev_devs, argv[1]);
- if (dummy_dev) {
- netdev_dev_dummy_set_admin_state(dummy_dev, up);
- } else {
- unixctl_command_reply_error(conn, "Unknown Dummy Interface");
- return;
+ for (i = 1; i < argc - 1; i++) {
+ struct netdev_dev_dummy *dummy_dev;
+
+ dummy_dev = shash_find_data(&dummy_netdev_devs, argv[i]);
+ if (dummy_dev) {
+ netdev_dev_dummy_set_admin_state(dummy_dev, up);
+ } else {
+ unixctl_command_reply_error(conn, "Unknown Dummy Interface");
+ return;
+ }
}
} else {
struct shash_node *node;
@@ -759,7 +763,7 @@ netdev_dummy_register(bool override)
"ICMP_ID [DST_MAC [SRC_MAC]]",
6, 8, netdev_dummy_pktgen, NULL);
unixctl_command_register("netdev-dummy/set-admin-state",
- "[netdev] up|down", 1, 2,
+ "[netdev] up|down", 1, INT_MAX,
netdev_dummy_set_admin_state, NULL);
if (override) {
--
1.7.2.5
More information about the dev
mailing list