[ovs-dev] [PATCH] ovs-vsctl: check if the device name is valid

Ben Pfaff blp at nicira.com
Fri Oct 26 14:44:20 UTC 2012

On Fri, Oct 26, 2012 at 09:22:35PM +0800, Cong Wang wrote:
> On 10/25/2012 11:20 PM, Ben Pfaff wrote:
> >Furthermore, ovs-vsctl is meant to be generic in the sense that you can
> >use an ovs-vsctl built in one place (on one OS) to control a switch and
> >database running elsewhere (on another OS).  You don't want to apply the
> >local host's restrictions to changes to a remote db.
> The problem without this patch is that when we add some port whose
> name is longer than IFNAMSIZ, ovs-vsctl doesn't give any error, the
> error is actually "hidden" in the log, which is actually written by
> ovs-vswitchd. So, it is not easy for inexperienced people to find
> where the error is.
> How about raising the console log level? So that such errors will be
> seen on the terminal.

ovs-vswitchd doesn't have a fd for the console; it daemonized itself and
closed that fd long ago.  (That's especially important if one started
ovs-vswitchd over an SSH connection; otherwise ovs-vswitchd holds the
SSH connection open.)

I think the key is probably to learn to look at the log if something
goes wrong.

More information about the dev mailing list