[ovs-dev] [PATCH] datapath: Fix sparse warning for symbol 'BUILD_BUG_ON_NOT_POWER_OF_2'

Jesse Gross jesse at nicira.com
Fri Oct 26 21:29:25 UTC 2012


On Thu, Oct 25, 2012 at 1:28 PM, Pravin Shelar <pshelar at nicira.com> wrote:
> On Thu, Oct 25, 2012 at 1:19 PM, Ben Pfaff <blp at nicira.com> wrote:
>> On Sat, Oct 27, 2012 at 01:07:24PM -0700, Pravin B Shelar wrote:
>>> Signed-off-by: Pravin B Shelar <pshelar at nicira.com>
>>
>> I'm curious, what warning does sparse give?  (You could add this to
>> the commit message.)
>>
> This symbol was moved from kernel.h to bug.h in 3.4.
> warning is as follows, I will add it to commit msg.
>
> include/linux/bug.h:15:9: warning: preprocessor token
> BUILD_BUG_ON_NOT_POWER_OF_2 redefined
> /root/ovs-cl1/stt-fl/datapath/linux/compat/include/linux/kernel.h:44:9:
> this was the original definition

Since the "correct" place for this on new kernels is in bug.h, it's
probably better to just move the whole definition there to make it
easier to find.  That would also solve this problem since bug.h
includes kernel.h



More information about the dev mailing list