[ovs-dev] [PATCH 3/4] User-Space MPLS actions and matches

Isaku Yamahata yamahata at valinux.co.jp
Mon Oct 29 02:06:35 UTC 2012


On Sat, Oct 27, 2012 at 02:39:37PM +0900, Simon Horman wrote:
> > Even when NX MPLS actions is used, retrieved actions always results in
> > OF1.1+ MPLS actions. We can keep it easily.
> > 
> > Set ofpact->compat = OFPUTIL_NX_xxx_MPLS in ofpact_from_nxact().
> > And then
> > if (a->compat == OFPUTIL_NXAST_xxx_MPLS) {
> >     NX MPLS action
> > } else {
> >     OF11+ MPLS action
> > }
> 
> Hi,
> 
> I'm not sure that this is a problem as the behaviour of the actions is the
> same. Am I missing something?

No, it's NOT a problem. Such behavior is only nice-to-have and
easy to implement. Anyway I can send a patch after your patch applied.
-- 
yamahata



More information about the dev mailing list