[ovs-dev] [Single DP 04/15] Use ODP ports in dpif layer and below.
jpettit at nicira.com
Mon Oct 29 21:21:52 UTC 2012
Huh, somehow I missed it in that 22 patch series. I just reviewed that one patch.
On Oct 29, 2012, at 2:14 PM, Ben Pfaff <blp at nicira.com> wrote:
> On Mon, Oct 29, 2012 at 02:11:51PM -0700, Justin Pettit wrote:
>> On Thu, Oct 18, 2012 at 4:42 PM, Ben Pfaff <blp at nicira.com> wrote:
>>> In ofproto_unixctl_trace(), it looks very much to me like the conversion
>>> to an ODP port in the argc == 6 case should not be happening, that is,
>>> that the ofp_port_to_odp_port call should be omitted here:
>>> uint32_t in_port = ofp_port_to_odp_port(atoi(in_port_s));
>> Fixed. Isn't this a bug in the existing code? Should I do a separate
>> patch to fix this in existing branches?
> I've had a fix for this on a local branch forever and I finally sent
> it out on Friday, so you can just review it here:
More information about the dev