[ovs-dev] [tests 20/22] ofproto-dpif: Fix "ofproto/trace" of flow for local port.

Ben Pfaff blp at nicira.com
Mon Oct 29 23:17:09 UTC 2012


Thanks, I pushed it to master.

On Mon, Oct 29, 2012 at 02:20:52PM -0700, Justin Pettit wrote:
> Acked-by: Justin Pettit <jpettit at nicira.com>
> 
> Thanks,
> 
> --Justin
> 
> 
> On Oct 25, 2012, at 5:02 PM, Ben Pfaff <blp at nicira.com> wrote:
> 
> > The 'in_port' variable is an OpenFlow port, not an ODP port, so we should
> > not translate it to ODP.
> > 
> > Signed-off-by: Ben Pfaff <blp at nicira.com>
> > ---
> > ofproto/ofproto-dpif.c |    2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
> > index 3e1b7b3..7d914c8 100644
> > --- a/ofproto/ofproto-dpif.c
> > +++ b/ofproto/ofproto-dpif.c
> > @@ -6811,7 +6811,7 @@ ofproto_unixctl_trace(struct unixctl_conn *conn, int argc, const char *argv[],
> >         const char *tun_id_s = argv[3];
> >         const char *in_port_s = argv[4];
> >         const char *packet_s = argv[5];
> > -        uint16_t in_port = ofp_port_to_odp_port(atoi(in_port_s));
> > +        uint16_t in_port = atoi(in_port_s);
> >         ovs_be64 tun_id = htonll(strtoull(tun_id_s, NULL, 0));
> >         uint32_t priority = atoi(priority_s);
> >         const char *msg;
> > -- 
> > 1.7.2.5
> > 
> > _______________________________________________
> > dev mailing list
> > dev at openvswitch.org
> > http://openvswitch.org/mailman/listinfo/dev
> 



More information about the dev mailing list