[ovs-dev] [Single DP 05/15] Allow the OpenFlow port to be requested for a port.

Ben Pfaff blp at nicira.com
Mon Oct 29 23:19:03 UTC 2012


On Mon, Oct 29, 2012 at 02:59:46PM -0700, Justin Pettit wrote:
> > It looks like the signed 64-bit value from the database gets truncated
> > down to an unsigned 16-bit value in iface_do_create().  Actually in
> > iface_create() too, in the initialization of 'ofp_port'.  I'd check that
> > it's in the valid range [1,OFPP_MAX) and use OFPP_NONE if not.
> 
> As you suggested later, I defined constraints in the database
> definition.  Is that sufficient?

I think so, thanks.

Everything else sounds good.



More information about the dev mailing list