[ovs-dev] [PATCH v2] datapath: Fix sparse warning for symbol 'BUILD_BUG_ON_NOT_POWER_OF_2'

Pravin Shelar pshelar at nicira.com
Tue Oct 30 03:49:56 UTC 2012


On Mon, Oct 29, 2012 at 7:07 PM, Jesse Gross <jesse at nicira.com> wrote:
> On Mon, Oct 29, 2012 at 2:32 PM, Pravin B Shelar <pshelar at nicira.com> wrote:
>> v1-v2:
>>         - Moved BUILD_BUG_ON_NOT_POWER_OF_2 symbol definition for bug.h
>> --8<--------------------------cut here-------------------------->8--
>>
>> BUILD_BUG_ON_NOT_POWER_OF_2 symbol is moved from kernel.h to
>> bug.h in 3.4.  Therefore sparse is giving warning:
>>
>> include/linux/bug.h:15:9: warning: preprocessor token
>> BUILD_BUG_ON_NOT_POWER_OF_2 redefined
>> ovs/datapath/linux/compat/include/linux/kernel.h:44:9:
>> this was the original definition
>>
>> Signed-off-by: Pravin B Shelar <pshelar at nicira.com>
>
> This needs to include bug.h in Modules.mk, otherwise it fails distcheck.

OK, I will post updated patch.



More information about the dev mailing list