[ovs-dev] [PATCH] Accept the traffic marked with RARP eth_type.

Ben Pfaff blp at nicira.com
Wed Oct 31 22:26:26 UTC 2012


On Wed, Oct 31, 2012 at 01:39:25PM -0700, Mehak Mahajan wrote:
> With this commit, OVS will accept the traffic with eth_type RARP.
> 
> Signed-off-by: Mehak Mahajan <mmahajan at nicira.com>

Don't ovs_flow_from_nlattrs() and ovs_flow_to_nlattrs(), in
datapath/flow.c, also need to handle the RARP case?

This commit allows matching on RARP fields via OpenFlow, so it should
update the comments on NXM_OF_ARP_* and NXM_NX_ARP_* in
include/openflow/nicira-ext.h to mention that the RARP ethertype is
allowed too.  Also, the "ovs-ofctl parse-nx-match" test in
tests/ovs-ofctl.at should be updated to test RARP field matching.

We should probably mention this new feature in NEWS.

I think the change to test-classifier.c is a mistake.  The code in
there isn't ready for more than two values, and probably isn't worth
fixing.

This still needs a review from Jesse, I think.



More information about the dev mailing list