[ovs-dev] [PATCH] Accept the traffic marked with RARP eth_type.

Mehak Mahajan mmahajan at nicira.com
Wed Oct 31 23:19:05 UTC 2012

Hey Ben,

Thanks a lot for reviewing this.

On Wed, Oct 31, 2012 at 3:26 PM, Ben Pfaff <blp at nicira.com> wrote:

> On Wed, Oct 31, 2012 at 01:39:25PM -0700, Mehak Mahajan wrote:
> > With this commit, OVS will accept the traffic with eth_type RARP.
> >
> > Signed-off-by: Mehak Mahajan <mmahajan at nicira.com>
> Don't ovs_flow_from_nlattrs() and ovs_flow_to_nlattrs(), in
> datapath/flow.c, also need to handle the RARP case?
> Sorry. I missed them earlier. I have made the changes.

> This commit allows matching on RARP fields via OpenFlow, so it should
> update the comments on NXM_OF_ARP_* and NXM_NX_ARP_* in
> include/openflow/nicira-ext.h to mention that the RARP ethertype is
> allowed too.  Also, the "ovs-ofctl parse-nx-match" test in
> tests/ovs-ofctl.at should be updated to test RARP field matching.
> I have updated the comments and also updated the test tests/ovs-ofctl.atfor RARP field matching.

> We should probably mention this new feature in NEWS.
> Done.

> I think the change to test-classifier.c is a mistake.  The code in
> there isn't ready for more than two values, and probably isn't worth
> fixing.
> Thanks for pointing this out. I have reverted this change.

> This still needs a review from Jesse, I think.

I will be uploading an updated patch for review..

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openvswitch.org/pipermail/ovs-dev/attachments/20121031/8440d3c4/attachment-0003.html>

More information about the dev mailing list