[ovs-dev] [PATCH] datapath: Fix FLOW_BUFSIZE definition.

Kyle Mestery (kmestery) kmestery at cisco.com
Tue Sep 4 01:42:12 UTC 2012


On Sep 3, 2012, at 5:24 PM, Jesse Gross wrote:
> This is analogous to the change made in userspace with
> 2508ac16defd417b94fb69689b6b1da4fbc76282 (odp-util: Update
> ODPUTIL_FLOW_KEY_BYTES for current kernel flow format.).  The extra
> space for vlan encapsulation was not included in the allocation for
> maximum length flows.
> 
> Found by code inspection and to my knowledge has never been hit, likely
> because skb allocations are padded out to a cacheline, making userspace
> more susceptible to this problem than the kernel.  In theory, however,
> the right combination of flow and packet size could result in a kernel
> panic.
> 
> Signed-off-by: Jesse Gross <jesse at nicira.com>

Looks good.

Acked-by: Kyle Mestery <kmestery at cisco.com>



More information about the dev mailing list